🐛 - fix: english text #682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #682 +/- ##
==========================================
- Coverage 90.32% 90.24% -0.09%
==========================================
Files 210 210
Lines 6172 6210 +38
Branches 648 669 +21
==========================================
+ Hits 5575 5604 +29
- Misses 597 606 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -1423,7 +1423,7 @@ msgstr[1] "" | |||
| #: openarchiefbeheer/logging/templates/logging/destruction_list_co_reviewers_added.txt:9 | |||
| #, python-format | |||
| msgid "They also removed these co-reviewers: %(removed_co_reviewers)s." | |||
| msgstr "" | |||
There was a problem hiding this comment.
Check dit ff met @SilviaAmAm, volgens mij wordt hier niet meervoud bedoeld.
There was a problem hiding this comment.
Ah yeah, het kan allebij zijn 🤔 ik check met Silvia
There was a problem hiding this comment.
Dit is inderdaad de "singular they" (ook op lijn 1447)
Xaohs
requested review from
svenvandescheur
and removed request for
SilviaAmAm
svenvandescheur
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #678